rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix dragging with visibility toggle

Browse Source
This commit is contained in:
Jay Kamat 2018-10-24 20:00:08 -07:00
parent 9727975914
commit 078f5f9f1c
No known key found for this signature in database
GPG Key ID: 5D2E399600F4F7B5
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
qutebrowser/mainwindow/tabwidget.py
View File

@ -226,7 +226,9 @@ class TabWidget(QTabWidget):
work. work.
""" """
bar = self.tabBar() bar = self.tabBar()
toggle = self.count() > 10 and bar.isVisible() toggle = (self.count() > 10 and
not bar.drag_in_progress and
bar.isVisible())
if toggle: if toggle:
bar.setUpdatesEnabled(False) bar.setUpdatesEnabled(False)
bar.setVisible(False) bar.setVisible(False)
@ -384,6 +386,7 @@ class TabBar(QTabBar):
self._on_show_switching_delay_changed() self._on_show_switching_delay_changed()
self.setAutoFillBackground(True) self.setAutoFillBackground(True)
self._set_colors() self._set_colors()
self.drag_in_progress = False
QTimer.singleShot(0, self.maybe_hide) QTimer.singleShot(0, self.maybe_hide)
def __repr__(self): def __repr__(self):
@ -507,8 +510,16 @@ class TabBar(QTabBar):
p.setColor(QPalette.Window, config.val.colors.tabs.bar.bg) p.setColor(QPalette.Window, config.val.colors.tabs.bar.bg)
self.setPalette(p) self.setPalette(p)
def mouseReleaseEvent(self, e):
"""Override mouseReleaseEvent to know when drags stop."""
self.drag_in_progress = False
super().mouseReleaseEvent(e)
def mousePressEvent(self, e): def mousePressEvent(self, e):
"""Override mousePressEvent to close tabs if configured.""" """Override mousePressEvent to close tabs if configured.
Also keep track of if we are currently in a drag."""
self.drag_in_progress = True
button = config.val.tabs.close_mouse_button button = config.val.tabs.close_mouse_button
if (e.button() == Qt.RightButton and button == 'right' or if (e.button() == Qt.RightButton and button == 'right' or
e.button() == Qt.MiddleButton and button == 'middle'): e.button() == Qt.MiddleButton and button == 'middle'):