From 06afd3604e4656ed9ccaceaf43cb6af9bbe11b7c Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Mon, 26 Nov 2018 23:30:55 +0100 Subject: [PATCH] Don't try to iterate over auth info This caused a crash when trying to use a proxy with authentication on QtWebKit. It was introduced in 3a5241b642da666e4517a32e0eb945254d86a6da since it was a namedtuple before and was iterable like this. --- qutebrowser/browser/webkit/network/networkmanager.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/qutebrowser/browser/webkit/network/networkmanager.py b/qutebrowser/browser/webkit/network/networkmanager.py index 31e9e815f..4c44ba887 100644 --- a/qutebrowser/browser/webkit/network/networkmanager.py +++ b/qutebrowser/browser/webkit/network/networkmanager.py @@ -297,9 +297,9 @@ class NetworkManager(QNetworkAccessManager): """Called when a proxy needs authentication.""" proxy_id = ProxyId(proxy.type(), proxy.hostName(), proxy.port()) if proxy_id in _proxy_auth_cache: - user, password = _proxy_auth_cache[proxy_id] - authenticator.setUser(user) - authenticator.setPassword(password) + authinfo = _proxy_auth_cache[proxy_id] + authenticator.setUser(authinfo.user) + authenticator.setPassword(authinfo.password) else: msg = '{} says:
{}'.format( html.escape(proxy.hostName()),