rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Handle all uerscript errors when hinting with userscript-target

Browse Source
This commit is contained in:
Florian Bruhin 2017-02-19 13:15:15 +01:00
parent 00a8e79311
commit 01db59ff36
3 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.asciidoc
View File

@ -67,6 +67,7 @@ Fixed
- Worked around a segfault when opening a URL after a QtWebEngine renderer process crash - Worked around a segfault when opening a URL after a QtWebEngine renderer process crash
- Using :undo or :tab-clone with a view-source:// or chrome:// tab is now prevented, as it segfaults - Using :undo or :tab-clone with a view-source:// or chrome:// tab is now prevented, as it segfaults
- `:navigate prev/next` now detects `rel` attributes on `<a>` elements - `:navigate prev/next` now detects `rel` attributes on `<a>` elements
- Fixed a crash when hinting with target `userscript` and spawning a non-existing script
v0.9.1 v0.9.1
------ ------

2
qutebrowser/browser/hints.py
View File

@ -316,7 +316,7 @@ class HintActions:
try: try:
userscripts.run_async(context.tab, cmd, *args, win_id=self._win_id, userscripts.run_async(context.tab, cmd, *args, win_id=self._win_id,
env=env) env=env)
except userscripts.UnsupportedError as e: except userscripts.Error as e:
raise HintingError(str(e)) raise HintingError(str(e))
def spawn(self, url, context): def spawn(self, url, context):

5
tests/end2end/features/hints.feature
View File

@ -81,6 +81,11 @@ Feature: Using hints
And I hint with args "all userscript (testdata)/userscripts/echo_hint_text" and follow a And I hint with args "all userscript (testdata)/userscripts/echo_hint_text" and follow a
Then the message "Follow me!" should be shown Then the message "Follow me!" should be shown
Scenario: Using :hint userscript with a script which doesn't exist
When I open data/hints/html/simple.html
And I hint with args "all userscript (testdata)/does_not_exist" and follow a
Then the error "Userscript '*' not found" should be shown
Scenario: Yanking to clipboard Scenario: Yanking to clipboard
When I run :debug-set-fake-clipboard When I run :debug-set-fake-clipboard
And I open data/hints/html/simple.html And I open data/hints/html/simple.html