From 013f906c3bc2ced7cfb388e1e7c3df5d55829db3 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Sun, 4 Jan 2015 20:15:45 +0100 Subject: [PATCH] hints: Small cleanup (add _show_url_error method). --- qutebrowser/browser/hints.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/qutebrowser/browser/hints.py b/qutebrowser/browser/hints.py index 8058c271f..22c723a0c 100644 --- a/qutebrowser/browser/hints.py +++ b/qutebrowser/browser/hints.py @@ -344,6 +344,11 @@ class HintManager(QObject): label.setPlainText(string) return label + def _show_url_error(self): + """Show an error because no link was found.""" + message.error(self._win_id, "No suitable link found for this element.", + immediately=True) + def _click(self, elem, context): """Click an element. @@ -432,9 +437,7 @@ class HintManager(QObject): """ url = self._resolve_url(elem, context.baseurl) if url is None: - message.error(self._win_id, - "No suitable link found for this element.", - immediately=True) + self._show_url_error() return download_manager = objreg.get('download-manager', scope='window', window=self._win_id) @@ -781,9 +784,7 @@ class HintManager(QObject): elif self._context.target in url_handlers: url = self._resolve_url(elem, self._context.baseurl) if url is None: - message.error(self._win_id, - "No suitable link found for this element.", - immediately=True) + self._show_url_error() return handler = functools.partial( url_handlers[self._context.target], url, self._context)