qutebrowser/tests/unit/misc/test_guiprocess.py

228 lines
8.1 KiB
Python
Raw Normal View History

2015-06-11 23:05:57 +02:00
# vim: ft=python fileencoding=utf-8 sts=4 sw=4 et:
# Copyright 2015 Florian Bruhin (The Compiler) <mail@qutebrowser.org>
#
# This file is part of qutebrowser.
#
# qutebrowser is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# qutebrowser is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with qutebrowser. If not, see <http://www.gnu.org/licenses/>.
"""Tests for qutebrowser.misc.guiprocess."""
import json
import logging
2015-06-11 23:05:57 +02:00
import pytest
from PyQt5.QtCore import QProcess, QIODevice
2015-06-11 23:05:57 +02:00
from qutebrowser.misc import guiprocess
@pytest.fixture(autouse=True)
2015-08-18 21:28:22 +02:00
def guiprocess_message_mock(message_mock):
message_mock.patch('qutebrowser.misc.guiprocess.message')
return message_mock
2015-06-11 23:05:57 +02:00
@pytest.yield_fixture()
def proc(qtbot):
"""A fixture providing a GUIProcess and cleaning it up after the test."""
p = guiprocess.GUIProcess(0, 'testprocess')
2015-06-11 23:05:57 +02:00
yield p
if p._proc.state() == QProcess.Running:
with qtbot.waitSignal(p.finished, timeout=10000) as blocker:
2015-06-11 23:05:57 +02:00
p._proc.terminate()
if not blocker.signal_triggered:
p._proc.kill()
@pytest.fixture()
def fake_proc(monkeypatch, stubs):
"""A fixture providing a GUIProcess with a mocked QProcess."""
p = guiprocess.GUIProcess(0, 'testprocess')
2015-06-11 23:05:57 +02:00
monkeypatch.setattr(p, '_proc', stubs.fake_qprocess())
return p
2015-09-09 19:25:34 +02:00
def test_start(proc, qtbot, guiprocess_message_mock, py_proc):
2015-06-11 23:05:57 +02:00
"""Test simply starting a process."""
with qtbot.waitSignals([proc.started, proc.finished], raising=True,
timeout=10000):
2015-09-09 19:25:34 +02:00
argv = py_proc("import sys; print('test'); sys.exit(0)")
2015-06-11 23:05:57 +02:00
proc.start(*argv)
2015-08-18 21:28:22 +02:00
assert not guiprocess_message_mock.messages
assert bytes(proc._proc.readAll()).rstrip() == b'test'
2015-09-09 19:25:34 +02:00
def test_start_verbose(proc, qtbot, guiprocess_message_mock, py_proc):
2015-08-18 21:28:22 +02:00
"""Test starting a process verbosely."""
proc.verbose = True
with qtbot.waitSignals([proc.started, proc.finished], raising=True,
timeout=10000):
2015-09-09 19:25:34 +02:00
argv = py_proc("import sys; print('test'); sys.exit(0)")
2015-08-18 21:28:22 +02:00
proc.start(*argv)
msgs = guiprocess_message_mock.messages
assert msgs[0].level == guiprocess_message_mock.Level.info
assert msgs[1].level == guiprocess_message_mock.Level.info
2015-08-18 21:28:22 +02:00
assert msgs[0].text.startswith("Executing:")
assert msgs[1].text == "Testprocess exited successfully."
2015-06-11 23:14:56 +02:00
assert bytes(proc._proc.readAll()).rstrip() == b'test'
2015-06-11 23:05:57 +02:00
2015-09-09 19:25:34 +02:00
def test_start_env(monkeypatch, qtbot, py_proc):
monkeypatch.setenv('QUTEBROWSER_TEST_1', '1')
env = {'QUTEBROWSER_TEST_2': '2'}
proc = guiprocess.GUIProcess(0, 'testprocess', additional_env=env)
2015-09-09 19:25:34 +02:00
argv = py_proc("""
import os
import json
import sys
env = dict(os.environ)
print(json.dumps(env))
sys.exit(0)
""")
with qtbot.waitSignals([proc.started, proc.finished], raising=True,
timeout=10000):
proc.start(*argv)
data = bytes(proc._proc.readAll()).decode('utf-8')
ret_env = json.loads(data)
assert 'QUTEBROWSER_TEST_1' in ret_env
assert 'QUTEBROWSER_TEST_2' in ret_env
@pytest.mark.qt_log_ignore('QIODevice::read.*: WriteOnly device', extend=True)
2015-09-09 19:25:34 +02:00
def test_start_mode(proc, qtbot, py_proc):
"""Test simply starting a process with mode parameter."""
with qtbot.waitSignals([proc.started, proc.finished], raising=True,
timeout=10000):
2015-09-09 19:25:34 +02:00
argv = py_proc("import sys; print('test'); sys.exit(0)")
proc.start(*argv, mode=QIODevice.NotOpen)
assert not proc._proc.readAll()
def test_start_detached(fake_proc):
2015-06-11 23:05:57 +02:00
"""Test starting a detached process."""
argv = ['foo', 'bar']
2015-06-11 23:05:57 +02:00
fake_proc._proc.startDetached.return_value = (True, 0)
fake_proc.start_detached(*argv)
fake_proc._proc.startDetached.assert_called_with(*list(argv) + [None])
def test_start_detached_error(fake_proc, guiprocess_message_mock):
"""Test starting a detached process with ok=False."""
argv = ['foo', 'bar']
fake_proc._proc.startDetached.return_value = (False, 0)
fake_proc._proc.error.return_value = "Error message"
fake_proc.start_detached(*argv)
msg = guiprocess_message_mock.getmsg(guiprocess_message_mock.Level.error,
immediate=True)
assert msg.text == "Error while spawning testprocess: Error message."
2015-09-09 19:25:34 +02:00
def test_double_start(qtbot, proc, py_proc):
2015-06-11 23:05:57 +02:00
"""Test starting a GUIProcess twice."""
with qtbot.waitSignal(proc.started, raising=True, timeout=10000):
2015-09-09 19:25:34 +02:00
argv = py_proc("import time; time.sleep(10)")
2015-06-11 23:05:57 +02:00
proc.start(*argv)
with pytest.raises(ValueError):
proc.start('', [])
2015-09-09 19:25:34 +02:00
def test_double_start_finished(qtbot, proc, py_proc):
2015-06-11 23:05:57 +02:00
"""Test starting a GUIProcess twice (with the first call finished)."""
with qtbot.waitSignals([proc.started, proc.finished], raising=True,
timeout=10000):
2015-09-09 19:25:34 +02:00
argv = py_proc("import sys; sys.exit(0)")
2015-06-11 23:05:57 +02:00
proc.start(*argv)
with qtbot.waitSignals([proc.started, proc.finished], raising=True,
timeout=10000):
2015-09-09 19:25:34 +02:00
argv = py_proc("import sys; sys.exit(0)")
2015-06-11 23:05:57 +02:00
proc.start(*argv)
def test_cmd_args(fake_proc):
2015-06-11 23:05:57 +02:00
"""Test the cmd and args attributes."""
cmd = 'does_not_exist'
args = ['arg1', 'arg2']
fake_proc.start(cmd, args)
assert (fake_proc.cmd, fake_proc.args) == (cmd, args)
2015-06-11 23:05:57 +02:00
def test_start_logging(fake_proc, caplog):
"""Make sure that starting logs the executed commandline."""
cmd = 'does_not_exist'
args = ['arg', 'arg with spaces']
with caplog.at_level(logging.DEBUG):
fake_proc.start(cmd, args)
msgs = [e.msg for e in caplog.records]
assert msgs == ["Starting process.",
"Executing: does_not_exist arg 'arg with spaces'"]
2015-08-18 21:28:22 +02:00
def test_error(qtbot, proc, caplog, guiprocess_message_mock):
2015-06-11 23:05:57 +02:00
"""Test the process emitting an error."""
with caplog.at_level(logging.ERROR, 'message'):
2015-09-16 20:26:31 +02:00
with qtbot.waitSignal(proc.error, raising=True, timeout=5000):
proc.start('this_does_not_exist_either', [])
2015-06-11 23:05:57 +02:00
msg = guiprocess_message_mock.getmsg(guiprocess_message_mock.Level.error,
immediate=True)
expected_msg = ("Error while spawning testprocess: The process failed to "
"start.")
2015-08-18 21:28:22 +02:00
assert msg.text == expected_msg
2015-06-11 23:05:57 +02:00
2015-09-09 19:25:34 +02:00
def test_exit_unsuccessful(qtbot, proc, guiprocess_message_mock, py_proc):
with qtbot.waitSignal(proc.finished, raising=True, timeout=10000):
2015-09-09 19:25:34 +02:00
proc.start(*py_proc('import sys; sys.exit(1)'))
2015-08-18 21:28:22 +02:00
msg = guiprocess_message_mock.getmsg(guiprocess_message_mock.Level.error)
assert msg.text == "Testprocess exited with status 1."
@pytest.mark.parametrize('stream', ['stdout', 'stderr'])
def test_exit_unsuccessful_output(qtbot, proc, caplog, py_proc, stream):
"""When a process fails, its output should be logged."""
with caplog.atLevel(logging.ERROR):
with qtbot.waitSignal(proc.finished, raising=True, timeout=10000):
proc.start(*py_proc("""
import sys
print("test", file=sys.{})
sys.exit(1)
""".format(stream)))
assert len(caplog.records) == 2
assert caplog.records[1].msg == 'Process {}:\ntest'.format(stream)
@pytest.mark.parametrize('stream', ['stdout', 'stderr'])
def test_exit_successful_output(qtbot, proc, py_proc, stream):
"""When a process suceeds, no output should be logged.
The test doesn't actually check the log as it'd fail because of the error
logging.
"""
with qtbot.waitSignal(proc.finished, raising=True, timeout=10000):
proc.start(*py_proc("""
import sys
print("test", file=sys.{})
sys.exit(0)
""".format(stream)))