From d13a1c64942ffbf87719dff62080b4fdfb5a47b2 Mon Sep 17 00:00:00 2001 From: "DeepBlueV7.X" Date: Wed, 25 Nov 2020 00:21:45 +0100 Subject: [PATCH] Apply suggestions from code review --- src/LoginPage.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/LoginPage.cpp b/src/LoginPage.cpp index 6d040c53..ac625db1 100644 --- a/src/LoginPage.cpp +++ b/src/LoginPage.cpp @@ -193,7 +193,7 @@ LoginPage::loginError(const QString &msg) auto rect = QFontMetrics(font()).boundingRect(msg); int width = rect.width(); int height = rect.height(); - error_label_->setFixedHeight(qCeil(width / 200 * height)); + error_label_->setFixedHeight(qCeil(width / 200) * height); error_label_->setText(msg); } @@ -211,7 +211,7 @@ LoginPage::isMatrixIdValid() QRegularExpressionValidator v(QRegularExpression("@.+?:.{3,}"), this); QString s = matrixid_input_->text(); int pos = 0; - return v.validate(s, pos); + return v.validate(s, pos) == QValidator::Acceptable; } void