rnhmjoj/nheko
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Document better rtp payload types

Browse Source
This commit is contained in:
trilene 2020-10-29 19:17:10 -04:00
parent c370dd8313
commit 51a559ab4a
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/WebRTCSession.cpp
View File

@ -607,7 +607,7 @@ addDecodeBin(GstElement *webrtc G_GNUC_UNUSED, GstPad *newpad, GstElement *pipe)
} }
bool bool
strstr_(std::string_view str1, std::string_view str2) contains(std::string_view str1, std::string_view str2)
{ {
return std::search(str1.cbegin(), return std::search(str1.cbegin(),
str1.cend(), str1.cend(),
@ -634,7 +634,7 @@ getMediaAttributes(const GstSDPMessage *sdp,
const gchar *rtpval = nullptr; const gchar *rtpval = nullptr;
for (guint n = 0; n == 0 || rtpval; ++n) { for (guint n = 0; n == 0 || rtpval; ++n) {
rtpval = gst_sdp_media_get_attribute_val_n(media, "rtpmap", n); rtpval = gst_sdp_media_get_attribute_val_n(media, "rtpmap", n);
if (rtpval && strstr_(rtpval, encoding)) { if (rtpval && contains(rtpval, encoding)) {
payloadType = std::atoi(rtpval); payloadType = std::atoi(rtpval);
break; break;
} }
@ -733,7 +733,13 @@ WebRTCSession::createOffer(bool isVideo)
haveVideoStream_ = false; haveVideoStream_ = false;
localsdp_.clear(); localsdp_.clear();
localcandidates_.clear(); localcandidates_.clear();
return startPipeline(111, isVideo ? 96 : -1); // dynamic payload types
// opus and vp8 rtp payload types must be defined dynamically
// therefore from the range [96-127]
// see for example https://tools.ietf.org/html/rfc7587
constexpr int opusPayloadType = 111;
constexpr int vp8PayloadType = 96;
return startPipeline(opusPayloadType, vp8PayloadType);
} }
bool bool