jobs: rework the backup script

jobs.nix

@@ -45,64 +45,73 @@ systemd.services.ydns = {
   };
 
 
-systemd.services.backup = {
-  description = "run system backup";
+  systemd.services.backup =
+  let
+    saved = ''
+      /etc/lvm
+      /var/lib
+      /home
+    '';
+
+    excluded = ''
+      /var/lib/systemd
+      /var/lib/udisks2
+      /var/lib/postgresql
+      /var/lib/matrix-synapse/media_store/url_cache
+      /var/lib/matrix-synapse/media_store/url_cache_thumbnails
+    '';
+
+  in {
+    description = "system backup";
     after   = [ "network-online.target" ];
     startAt = "weekly";
 
-  serviceConfig.Type = "oneshot";
-
-  path = with pkgs; [ bup git nfs-utils ];
+    serviceConfig = {
+      Type = "oneshot";
+      PrivateTmp = true;
+      LimitNOFILE = 65536;
+    };
 
     environment.BUP_DIR = "/mnt/backup";
+    path = with pkgs; [ bup git nfs-utils sudo gzip postgresql ];
 
     script = ''
-    ${pkgs.fish}/bin/fish << 'EOF'
+      set -e
 
-    set locations \
-      /etc/lvm    \
-      /etc/nixos  \
-      /var/lib    \
-      /home
-
-    set excluded       \
-      /var/lib/alsa    \
-      /var/lib/systemd \
-      /var/lib/udisks2 \
-      /var/lib/udev    \
-      /var/lib/postgresql
-
-    # mount NFS share
-    mkdir -p $BUP_DIR
-    mount.nfs -o nolock 192.168.1.3:/maxwell $BUP_DIR
-
-    # check if properly mounted
-    if not mountpoint -q $BUP_DIR
-      echo mount failed! 1>&2
-      exit 1
-    end
+      # mount repository
+      mkdir -p "$BUP_DIR"
+      mount.nfs -o nolock 192.168.1.3:/maxwell "$BUP_DIR"
 
       # init backup
-    if not test -e $BUP_DIR/bupindex
-      bup init
-    end
+      ! test -e $BUP_DIR/bupindex && bup init
 
-    # build indices and copy
-    for i in $locations
-      eval bup index $i --exclude=(string join " --exclude=" $excluded)
-      bup save -n (basename $i) $i
-    end
+      # build indices and save
+      saved=${pkgs.writeText "backup-saved" saved}
+      excluded=${pkgs.writeText "backup-excluded" excluded}
+      while read -r dir; do
+        name=$(basename "$dir")
+
+        echo indexing $name...
+        bup index "$dir" --exclude-from="$excluded"
+        echo done
+
+        echo saving $name...
+        bup save -n "$name" "$dir"
+        echo done
+      done < "$saved"
 
       # postgresql backup
-    set dir /var/lib/postgresql-backup
-    mkdir -p $dir
-    sudo -u postgres pg_dumpall | gzip > $dir/db.bak
-    bup index $dir
-    bup save -n postgresql $dir
-    rm -rf $dir
+      dir=/tmp/postgresql
+      mkdir -p "$dir"
 
-    umount /mnt/backup
-    EOF
+      echo dumping databases...
+      sudo -u postgres pg_dumpall | gzip > "$dir"/db.bak
+      echo done
+
+      echo saving...
+      bup index "$dir"
+      bup save -n postgresql "$dir" --strip-path=/tmp
+      echo done
     '';
   };