rnhmjoj/asjon
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

miglior gestione di un 404 nel recupero dei coverage report

Browse Source
This commit is contained in:
Enrico Fasoli 2015-09-24 15:26:48 +02:00
parent ff0d335d71
commit 7fae59beeb
2 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
scripts/drone.coffee
View File

@ -23,6 +23,9 @@ module.exports = (robot) ->
try try
report = JSON.parse body report = JSON.parse body
catch e catch e
if /^404/g.test body
return res.send 'Coverage report non disponibile (404) forse \
non è ancora stato generato?'
return res.send 'Errore: '+e+'\n\nRisposta del server: '+body return res.send 'Errore: '+e+'\n\nRisposta del server: '+body
unless report?.files?.push? and report?.coverage?.toFixed? unless report?.files?.push? and report?.coverage?.toFixed?
return res.send 'Errore: informazioni insufficienti' return res.send 'Errore: informazioni insufficienti'

9
test/drone-test.coffee
View File

@ -39,6 +39,15 @@ describe 'modulo drone', ->
done() done()
asjon.send 'asjon coverage' asjon.send 'asjon coverage'
it 'dovrebbe reagire correttamente quando il report non è disponibile (404)', (done) ->
nock('https://drone.io')
.get('/github.com/fazo96/asjon/files/coverage/coverage.json')
.reply 404, '404 page not found'
asjon.receive (e,l) ->
l.join().should.match /^Coverage report non disponibile/g
done()
asjon.send 'asjon coverage'
it 'dovrebbe parsare correttamente il report json', (done) -> it 'dovrebbe parsare correttamente il report json', (done) ->
nock('https://drone.io') nock('https://drone.io')
.get('/github.com/fazo96/asjon/files/coverage/coverage.json') .get('/github.com/fazo96/asjon/files/coverage/coverage.json')